Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrate AllDomains to helium wallet #416

Merged
merged 2 commits into from
Aug 10, 2023
Merged

integrate AllDomains to helium wallet #416

merged 2 commits into from
Aug 10, 2023

Conversation

crypt0miester
Copy link
Contributor

gm team,

here a summary of what is done on the pr:

  • add @onsol/tldparser npm package
  • add TldParser function to retrieve domain owner (getDomainOwner.ts)
  • add debouncing to avoid unnecessary rpc calls while the user types the domain in PaymentItem.tsx (which is handled in PaymentScreen.tsx)
  • if the text contains a dot handleAddressError would just retrieve the address from the already set address from handleEditAddress
  • add alias/nickname as the domain when applicable to when the user adds an AllDomain domain.

regards,
miester.

@crypt0miester
integrate alldomains to helium wallet:
e846a09 
* add TldParser to retrieve domain owner
* add debounce to avoid unneccessary rpc calls
* add alias/nickname as the domain when applicable
@crypt0miester crypt0miester requested a review from a team as a code owner August 9, 2023 11:50
@crypt0miester crypt0miester requested review from allenan, matthewcarlreetz and elsie-c and removed request for a team August 9, 2023 11:50
@ChewingGlass ChewingGlass merged commit c53aee4 into helium:main Aug 10, 2023
1 check passed
ChewingGlass added a commit that referenced this pull request Aug 10, 2023
@ChewingGlass
Revert "integrate alldomains to helium wallet: (#416)"
0a76e6d 
This reverts commit c53aee4.
ChewingGlass added a commit that referenced this pull request Aug 10, 2023
@ChewingGlass
Revert "integrate alldomains to helium wallet: (#416)" (#419)
426655d 
This reverts commit c53aee4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChewingGlass ChewingGlass ChewingGlass approved these changes

@allenan allenan Awaiting requested review from allenan allenan is a code owner automatically assigned from helium/app-team

@matthewcarlreetz matthewcarlreetz Awaiting requested review from matthewcarlreetz matthewcarlreetz is a code owner automatically assigned from helium/app-team

@elsie-c elsie-c Awaiting requested review from elsie-c elsie-c is a code owner automatically assigned from helium/app-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crypt0miester @ChewingGlass